[PATCH] Fix Python 2.6 deprecation warnings

[guest]

Python 2.6 has been released a while ago and running HellaNZB using this Python version causes a couple of deprecation warnings to appear, which of course doesn't really affect the execution of HellaNZB. The usage of the md5 module and the BaseException?.message property have been deprecated.

A simple patch is attached. It ensures that the deprecation warnings don't show up anymore using Python 2.6 while preserving Python >=2.3 compatibility.

The reason why I decided to create this patch and this ticket is because two ArchLinux? users have experienced problems [1] with HellaNZB in conjunction with LottaNZB and Python 2.6 because of these deprecation warnings. We're still investigating the issue.

[1]  http://bbs.archlinux.org/viewtopic.php?pid=508538#p508538

[guest]

By the way: The deprecation warnings emitted by Twisted will be fixed [1] in the next version.

I'm really sorry that I didn't show up in #hellanzb during the past weeks. On one hand, a new semester at university has started once more, which kept me busy, and on the other hand, I was getting kind of cold feet because I wasn't sure if I had the time to do serious work on HellaNZB. What I know for sure is that we cannot let this lovely project die.

When we first got in contact with you, we might have been a little harsh. We don't expect you to grant us Subversion access for the time being, because we wouldn't do that either if we were you. However, the combination of Trac/Subversion make collaboration quite painful. It's not even possible to register an account and the concept of patches is kind of obsolete in the time of DVCS like Git or Bazaar. First, I didn't want to bring up this idea already, but it would be a good idea to move HellaNZB's codebase and tickets to a platform that makes collaboration easier. This might also attract new developers. I was thinking about something like Launchpad.net or Github etc. I personally prefer Launchpad.net because we've been using it for more than a year and I must say that collaboration has never been easier.

I guess I'll try to create a few more patches in the coming weeks and/or create some blueprints.

Kind regards, Severin Heiniger aka Lantash (LottaNZB developer)

[1]  http://twistedmatrix.com/trac/ticket/2763

[guest]

Replying to guest:

First, I didn't want to bring up this idea already, but it would be a good idea to move HellaNZB's codebase and tickets to a platform that makes collaboration easier. This might also attract new developers. I was thinking about something like Launchpad.net or Github etc. I personally prefer Launchpad.net because we've been using it for more than a year and I must say that collaboration has never been easier.

I second that vote for a switch away from trac, or at least open up the user registration again, so we don't have to keep using guest. -BassKozz

[guest]

The patch caused HellaNZB to break because of the differences between the deprecated md5 module and the new hashlib module. I cannot explain how I could not notice this while creating the patch in the first place. Here's a fixed version that will hopefully work well.

Could somebody give it a try in order to confirm it?

[guest]

Fixes Python 2.6 deprecation warnings (updated)

[pjenvey]

fixed in r1098